Skip to content

Resolve "BSV: Replace `d-none` in `toaster.js`"

Vanessa Ottorequested to merge
2988-bsv-replace-d-none-in-toaster-js into main

What does this MR do?

I tried to find out whether this class is even used or not. I went into toast.js and set the duration longer, from:

const MIN_DURATION = 1000
const MIN_DURATION = 100000

to be able to test around a bit. What I can find in the DOM is the static class 'b-toaster-slot', as I am always running into doRender.

doRender is false when: // We don't render on SSR or if a an existing target found.

This might be very edge-casey. I'd tested this out by setting this.doRender = true in line 87 to this.doRender = false. Then I replaced d-none with gl-hidden, which is both display: none;. As far as I can see, the default !important which is attached to every BootstrapCSS Util Class should not be necessary.

I can't find any style for b-dead-toaster at all, but I chose to ignore this in the scope of this MR.

Screenshots or screen recordings

Before After
Screenshot_2024-11-06_at_16.39.33 Screenshot_2024-11-06_at_16.40.27

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2988 (closed)

Merge request reports