Skip to content

Remove vertical + card designs from GlTabs and GlNav

Vanessa Otto requested to merge 2986-bsv-replace-h-100-in-tabs-js into epic-15765

What does this MR do?

Video explanation:

output

Written explanation:

The styles vertical and card will be removed from GlTabs. The style vertical will be removed from Glnav. They were not documented in Storybook or https://design.gitlab.com/components/tabs. Since we pass properties along to BootstrapVue without a filter, it was technically possible to pass properties to enable these styles though:

Screenshots or screen recordings

The following styles will be removed:

Vertical tabs

Screenshot_2024-11-07_at_15.09.18

Vertical nav

Screenshot_2024-11-07_at_15.09.32

Tabs in card style

Screenshot_2024-11-07_at_15.10.56

Vertical tabs in card style

Screenshot_2024-11-07_at_15.09.59

Integration merge requests

Not required. Neither vertical nor card is used in combination with gl-tabs in the projects. And GlNav is not used at all.

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2986 (closed) #2978 (closed) #2985 (closed) #2984 (closed)

Edited by Vanessa Otto

Merge request reports

Loading