Skip to content

feat(GlButton): Remove pill and squared properties

Vanessa Otto requested to merge 2821-use-design-tokens-in-bootstrap-reset-and-variables--button into 2821-use-design-tokens-in-bootstrap-reset-and-variables

What does this MR do?

feat(GlButton): Remove pill and squared properties

BREAKING CHANGE: The GlButton does not support the properties 'pill' and 'squared' anymore. Prefer using the styles with the usual border radius. When absolutely necessary, apply GitLab UI Util CSS classes to override the border radius

Screenshots or screen recordings

Screenshot_2024-10-30_at_15.09.51

Screenshot_2024-10-30_at_15.37.51

Integration merge requests

Luckily, not required

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2821

Merge request reports