Skip to content
Snippets Groups Projects

Resolve "Remove BootstrapVue Nuxt Docs"

Merged Vanessa Otto requested to merge 2913-remove-bootstrapvue-nuxt-docs into main
All threads resolved!

What does this MR do?

Remove all docs files except ./docs/assets.

  1. Why?
    • Last week I wanted to remove <b-navbar> because it's not used anywhere, and I don't have the feeling that we'd need to support it.
    • But then, <b-navbar> remained in the codebase in the docs
    • So I decided to first remove the docs to prevent confusions
    • These docs are not the Component docs, but the Nuxt Documentation website of BootstrapVue.
  2. Why not assets?
    • Because used in src/scss/storybook.scss for README doc styles.
  3. I'm not 100% sure if I really catched all traces I can delete now. Overall the nuxt config is still the same, and we also still have the dist folder, esm folder, etc. But since they're not in the way of migrating components, I decided to not check those files further for now.

Screenshots or screen recordings

Non available

Integration merge requests

Not required

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2913 (closed)

Edited by Vanessa Otto

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Lukas Eipert
  • Lukas Eipert
  • Lukas Eipert
  • Lukas Eipert
  • Lukas Eipert
  • Lukas Eipert
  • @vanessaotto I got this diff to work fine locally:

    diff --git a/src/vendor/bootstrap-vue/package.json b/src/vendor/bootstrap-vue/package.json
    index 7af6e3f56..a5c6dcc56 100644
    --- a/src/vendor/bootstrap-vue/package.json
    +++ b/src/vendor/bootstrap-vue/package.json
    @@ -79,11 +79,6 @@
         "@babel/plugin-transform-modules-commonjs": "^7.14.0",
         "@babel/plugin-transform-runtime": "^7.16.5",
         "@babel/preset-env": "^7.14.2",
    -    "@nuxt/content": "^1.14.0",
    -    "@nuxtjs/google-analytics": "^2.4.0",
    -    "@nuxtjs/pwa": "^3.3.5",
    -    "@nuxtjs/robots": "^2.5.0",
    -    "@nuxtjs/sitemap": "^2.4.0",
         "@testing-library/jest-dom": "^5.12.0",
         "@vue/compat": "^3.2.40",
         "@vue/compiler-dom": "^3.2.40",
    @@ -96,7 +91,6 @@
         "babel-plugin-istanbul": "^6.0.0",
         "clean-css-cli": "^4.3.0",
         "core-js": "^3.12.1",
    -    "cross-env": "^7.0.3",
         "eslint": "^7.26.0",
         "eslint-config-prettier": "^8.3.0",
         "eslint-config-standard": "^16.0.2",
    @@ -108,12 +102,10 @@
         "eslint-plugin-prettier": "^3.4.1",
         "eslint-plugin-promise": "^5.1.0",
         "eslint-plugin-vue": "^7.9.0",
    -    "html-loader": "^1.3.2",
         "improved-yarn-audit": "^3.0.0",
         "jest": "^26.6.3",
    -    "loader-utils": "^2.0.0",
    +    "jiti": "^1.9.2",
         "lodash": "^4.17.21",
    -    "nuxt": "^2.15.8",
         "postcss": "^8.2.15",
         "postcss-cli": "^8.3.1",
         "prettier": "1.14.3",
    @@ -123,7 +115,6 @@
         "rollup-plugin-commonjs": "^10.1.0",
         "rollup-plugin-node-resolve": "^5.2.0",
         "sass": "^1.45.0",
    -    "sass-loader": "^10.1.1",
         "terser": "^5.15.0",
         "vue": "^2.6.12",
         "vue-router": "^3.5.1",

    (need to run yarn afterwards)

  • Unassigning myself to keep my backlog clean. Please re-assign once you have had a look.

  • Lukas Eipert removed review request for @leipert

    removed review request for @leipert

  • Vanessa Otto mentioned in merge request !4684 (merged)

    mentioned in merge request !4684 (merged)

  • Vanessa Otto added 2 commits

    added 2 commits

    Compare with previous version

  • Lukas Eipert requested review from @leipert

    requested review from @leipert

  • Lukas Eipert resolved all threads

    resolved all threads

  • Lukas Eipert added 3 commits

    added 3 commits

    • 9fac1818 - docs: Re-add BootstrapVue Docs References
    • 10205e6a - docs: Update links
    • 6b87fd46 - Merge branch '2913-remove-bootstrapvue-nuxt-docs--readding-docs' into...

    Compare with previous version

  • Lukas Eipert approved this merge request

    approved this merge request

  • Lukas Eipert enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • merged

  • Lukas Eipert mentioned in commit f75d8aca

    mentioned in commit f75d8aca

  • added workflowcomplete label and removed workflowin review label

  • Please register or sign in to reply
    Loading