Resolve "Remove BootstrapVue Nuxt Docs"
What does this MR do?
Remove all docs
files except ./docs/assets
.
- Why?
- Last week I wanted to remove
<b-navbar>
because it's not used anywhere, and I don't have the feeling that we'd need to support it. - But then,
<b-navbar>
remained in the codebase in thedocs
- So I decided to first remove the
docs
to prevent confusions - These
docs
are not the Component docs, but the Nuxt Documentation website of BootstrapVue.
- Last week I wanted to remove
- Why not assets?
- Because used in
src/scss/storybook.scss
for README doc styles.
- Because used in
- I'm not 100% sure if I really catched all traces I can delete now. Overall the nuxt config is still the same, and we also still have the
dist
folder,esm
folder, etc. But since they're not in the way of migrating components, I decided to not check those files further for now.
Screenshots or screen recordings
Non available
Integration merge requests
Not required
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidelines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above). -
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Closes #2913 (closed)
Merge request reports
Activity
changed milestone to %17.6
assigned to @vanessaotto
2 Warnings This merge request is definitely too big (16955 lines changed), please split it into multiple merge requests. This MR will trigger no release No release
This Merge Request will trigger no release. This means none of the commits warrant a semantic release according to conventional commits rules (e.g. they only update CI config).
To trigger a release, update one or more commit messages.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend @blabuschagne
(UTC+2, same timezone as author)
@janis
(UTC+2, same timezone as author)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 7 commits
-
42d607bc...7aff4783 - 6 commits from branch
main
- 7c6a3730 - chore: Remove BootstrapVue Doc Pages
-
42d607bc...7aff4783 - 6 commits from branch
added workflowin review label and removed workflowin dev label
Hi @leipert, another BootstrapVue removal cleanup MR. This time I removed the Nuxt-website-pages.
requested review from @leipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
@vanessaotto I got this diff to work fine locally:
diff --git a/src/vendor/bootstrap-vue/package.json b/src/vendor/bootstrap-vue/package.json index 7af6e3f56..a5c6dcc56 100644 --- a/src/vendor/bootstrap-vue/package.json +++ b/src/vendor/bootstrap-vue/package.json @@ -79,11 +79,6 @@ "@babel/plugin-transform-modules-commonjs": "^7.14.0", "@babel/plugin-transform-runtime": "^7.16.5", "@babel/preset-env": "^7.14.2", - "@nuxt/content": "^1.14.0", - "@nuxtjs/google-analytics": "^2.4.0", - "@nuxtjs/pwa": "^3.3.5", - "@nuxtjs/robots": "^2.5.0", - "@nuxtjs/sitemap": "^2.4.0", "@testing-library/jest-dom": "^5.12.0", "@vue/compat": "^3.2.40", "@vue/compiler-dom": "^3.2.40", @@ -96,7 +91,6 @@ "babel-plugin-istanbul": "^6.0.0", "clean-css-cli": "^4.3.0", "core-js": "^3.12.1", - "cross-env": "^7.0.3", "eslint": "^7.26.0", "eslint-config-prettier": "^8.3.0", "eslint-config-standard": "^16.0.2", @@ -108,12 +102,10 @@ "eslint-plugin-prettier": "^3.4.1", "eslint-plugin-promise": "^5.1.0", "eslint-plugin-vue": "^7.9.0", - "html-loader": "^1.3.2", "improved-yarn-audit": "^3.0.0", "jest": "^26.6.3", - "loader-utils": "^2.0.0", + "jiti": "^1.9.2", "lodash": "^4.17.21", - "nuxt": "^2.15.8", "postcss": "^8.2.15", "postcss-cli": "^8.3.1", "prettier": "1.14.3", @@ -123,7 +115,6 @@ "rollup-plugin-commonjs": "^10.1.0", "rollup-plugin-node-resolve": "^5.2.0", "sass": "^1.45.0", - "sass-loader": "^10.1.1", "terser": "^5.15.0", "vue": "^2.6.12", "vue-router": "^3.5.1",
(need to run
yarn
afterwards)removed review request for @leipert
mentioned in merge request !4684 (merged)
added 2 commits
requested review from @leipert
started a merge train
mentioned in commit f75d8aca
added workflowcomplete label and removed workflowin review label