fix(GlBreadcrumb): Fix items watcher behavior
What does this MR do?
Before this change, even with auto-resize set to false, a change of the items
props would trigger a watcher that would then call the auto-resize logic, ignoring the value of auto-resize
Fixes #2906 (closed).
Screenshots or screen recordings
Before | After |
---|---|
recording_1727779290588 | recording_1727779333631 |
How to reproduce bug and fix locally
- Start
yarn storybook
- Go to https://gitlab-org.gitlab.io/gitlab-ui/?path=/story/base-breadcrumb--collapsed-items&args=autoResize:!false
- In the Controls tab, edit the
items
prop (by clicking "Raw" and editing the JSON) - The bug (on
main
): Theitems
watcher triggers a resize, collapsing items, even thoughauto-resize
is disabled. - The fix (this branch): The
items
watcher returns early, doing nothing (but marking all items as "fitting").
Integration merge requests
Not needed here.
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidelines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above). -
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Edited by Thomas Hutterer