Skip to content

feat(Alert): Ensure Alert actions can wrap

Chad Lavimoniererequested to merge
496658-alert-action-buttons-need-small-overflow-small-viewport-styling into main

What does this MR do?

When the viewport is very narrow, style alert actions differently. Also allow for alert actions to wrap if any of them have very long contents.

Screenshots or screen recordings

Before After
image Screenshot_2024-09-30_at_17.02.14
4f9237983d6b2cc1b52bcdb66206e9d0 d2726c5b32bcf6b44bfbdad845420994

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to gitlab#496658 (closed), gitlab#474921 (closed)

Edited by Chad Lavimoniere

Merge request reports