Skip to content
Snippets Groups Projects

feat(GlDuoChat): view context item content/details

Merged Elwyn Benson requested to merge view-context-item-details into main
All threads resolved!

What does this MR do?

feat(GlDuoChat): view context item content/details

  • adds support for view context item content/details
  • clicking selected context item of type file/git will emit event to load additional data, and displays in new details modal
  • adds hook for syntax highlighting the content from consumer applications, in the same manner the chat highlighting is done (via provided renderGFM fn)

This MR is a continuation from !4615 (merged)

Screenshots or screen recordings

Note: syntax highlighting is applied by external consumers of Duo Chat (e.g. VSCode) and so does not show within Storybook

context-item-details

image Modal loading state

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Elwyn Benson

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jannik Lehmann
  • Elwyn Benson added 3 commits

    added 3 commits

    • 127691f7 - 1 commit from branch local-git-context-category
    • f78b5ff9 - feat(GlDuoChat): view context item content/details
    • 91622875 - refactor: apply reviewer suggestions

    Compare with previous version

  • Elwyn Benson added 1 commit

    added 1 commit

    • 63909dd7 - feat(GlDuoChat): view context item content/details

    Compare with previous version

  • Jannik Lehmann approved this merge request

    approved this merge request

    • Resolved by Elwyn Benson

      Thanks for working on this @elwyn-gitlab LGTM! I have one non-blocking thing, so happy to approve as is and take care of this in a follow-up :thumbsup:

      Small friendly reminder, with MR's in review, please don't squash the commits since this does make finding the new changes tedious, thank you!

  • Elwyn Benson added 1 commit

    added 1 commit

    • 8e8a4c3d - fix: don't open details modal if selecting close button via keyboard

    Compare with previous version

  • Elwyn Benson requested review from @ohoral

    requested review from @ohoral

  • I have reviewed the merge request and left a mix of questions and recommendations. The review covers topics such as security concerns with the v-safe-html directive, test specificity, event handling, and potential Vue version compatibility. I estimate there is a decent amount of work required to address these points, though this is only an estimate based on the comments provided.

    · Leave feedback
    Edited by GitLab Duo
  • GitLab Duo
  • GitLab Duo
  • GitLab Duo
  • Elwyn Benson added 2 commits

    added 2 commits

    • 0be0f5d1 - refactor: rename component for more clarity
    • b255422c - chore: apply reviewer suggestions

    Compare with previous version

  • Olena Horal-Koretska approved this merge request

    approved this merge request

  • Olena Horal-Koretska resolved all threads

    resolved all threads

  • Olena Horal-Koretska enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • Olena Horal-Koretska resolved all threads

    resolved all threads

  • Olena Horal-Koretska removed this merge request from the merge train because the pipeline did not succeed. Learn more.

    removed this merge request from the merge train because the pipeline did not succeed. Learn more.

  • Olena Horal-Koretska enabled automatic add to merge train when checks pass

    enabled automatic add to merge train when checks pass

  • mentioned in commit 0889f495

  • Please register or sign in to reply
    Loading