Skip to content

feat(GlDuoChat): add initial context item menu component

Elwyn Bensonrequested to merge
duo-chat-context-menu-1 into main

What does this MR do?

This MR is part of a series of changes breaking down this initial MR.

Eventually, the component will allow searching and selecting context items from various categories, whcih get pinned to the Duo Chat conversation as context items.

MR Status
feat(GlDuoChat): display attached context in ch... (!4540 - merged) workflowcomplete
feat(GlDuoChat): add initial context item menu ... (!4573 - merged) workflowcomplete <-- you are here
feat(GlDuoChat): improved styling for context m... (!4574 - merged) ⏳
feat(GlDuoChat): context menu initial items sea... (!4575 - merged) ⏳
feat(GlDuoChat): improved styling for context m... (!4576 - merged) ⏳
feat(GlDuoChat): add context menu keyboard inte... (!4577 - merged) ⏳
feat(GlDuoChat): integrate context item menu wi... (!4560 - merged) ⏳
fix(GlDuoChat): update context-items-menu compo... (!4581 - merged) ⏳

This MR:

feat: add initial duo chat context item menu component

  • partial implementation, not yet very functional. Scaffolds initial component structure and tests and story.
  • allows selecting category and item
  • no proper rendering of categories or items yet
  • expands existing context-item-selections component to allow removing items

Screenshots or screen recordings

header header
image categories list
image items list
image selected items (removable)

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Elwyn Benson

Merge request reports