fix(DuoChat): Remove the 'clean' slash command
GitLab Integration MR: Remove clean slash command (gitlab!166979 - merged)
What does this MR do?
Resolves: DuoChat: Remove undocumented /clean command (#2788 - closed)
Removes all instances of /clean
command.
Screenshots or screen recordings
Behavior before: The behavior before is to not show /clean
as a slash command already. The correct slash command to return the UI back to it's original state is /clear
. The video below shows the UI in the integration branch NOT returning to it's original state when executing the /clean
command, which is the expected behavior.
Integration merge requests
-
GitLab: Remove clean slash command (gitlab!166979 - merged) -
JetBrains Extension: fix(JetBrains): Remove clean slash command (gitlab-org/editor-extensions/gitlab-jetbrains-plugin!1115 - merged) -
VSCode Extension: fix(Duo Chat): Remove clean slash command (gitlab-vscode-extension!2035 - merged) -
CustomersDot: mr_url -
Status Page: mr_url
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidelines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above). -
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Merge request reports
Activity
assigned to @dbernardi
changed milestone to %17.3
marked the checklist item ****GitLab: mr_url as completed
Major release (conventional commits)This Merge Request will trigger a major release of GitLab UI, triggered by commit: eb10c71d
This will bump the first part of the version number, e.g.
v1.2.3
->v2.0.0
.This means that GitLab UI has a breaking change.
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend @ntepluhina
(UTC+2, 9 hours ahead of author)
@svedova
(UTC+2, 9 hours ahead of author)
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded devopscreate groupduo chat sectiondev labels
added Category:Duo Chat label
added bugfunctional typebug labels
added 1 commit
- 848c7d41 - fix(DuoChat): Remove all mentions of clean slash command
@jannik_lehmann I think these are the code changes that we are looking for! Mind giving a review here on code and contributing to
@gitlab/ui
as this is my first MR here.requested review from @jannik_lehmann
- Resolved by Dylan Bernardi
@dbernardi Before I review, could you please help me with reproducing the behavior and add screenshots of the changes to this Merge Request?
I assume merging these changes will require migration changes in the host systems. If so, we need to mark this MR as a breaking change. Source
mentioned in epic &14535 (closed)
@jannik_lehmann I have not been able to set up my GDK yet, but that is planned for later this week. I have set this to milestone 17.4 as a result.
changed milestone to %17.4
Dylan Bernardi, this merge request has policy violations and errors. To unblock this merge request, fix these items:
- Resolve all violations in the following merge request approval policies: MR approvals policy.
- Acquire approvals from eligible approvers defined in the following merge request approval policies: MR approvals policy.
If you think these items shouldn't be violations, ask eligible approvers of each policy to approve this merge request.
mentioned in issue gitlab#473261 (closed)
removed review request for @jannik_lehmann
changed milestone to %17.5
mentioned in merge request gitlab!166979 (merged)
added 3055 commits
-
848c7d41...ef53c51c - 3054 commits from branch
main
- 4066f394 - fix(DuoChat): Remove all mentions of clean slash command
-
848c7d41...ef53c51c - 3054 commits from branch
added workflowin dev label
mentioned in issue #2788 (closed)
added 65 commits
-
4066f394...483f3629 - 64 commits from branch
main
- 06312ebd - fix(DuoChat)!: Remove the clean slash command
-
4066f394...483f3629 - 64 commits from branch
added 1 commit
- eb10c71d - fix(DuoChat): Remove the clean slash command
requested review from @jannik_lehmann
- Resolved by Dylan Bernardi
Hi @jannik_lehmann, long time coming, but this is ready for a look if you have some time! Otherwise I can pass it off to others that were selected by the bot
mentioned in merge request gitlab-org/editor-extensions/gitlab-jetbrains-plugin!1115 (merged)
mentioned in merge request gitlab-vscode-extension!2035 (merged)
@pgascouvaillancourt Could you maintainerize this gitlab-ui/Duo Chat MR?
If you like what you see, since this is a breaking change please stay away from the merge-button for a second, this comment has all the details why: !4415 (comment 2150270007)
Thank you!
requested review from @pgascouvaillancourt and removed review request for @jannik_lehmann
removed review request for @pgascouvaillancourt
mentioned in epic gitlab-org#14535 (closed)
requested review from @psimyn
started a merge train
added workflowin review label and removed workflowin dev label
mentioned in commit e56b677d
added workflowcomplete label and removed workflowin review label
added UX label