Skip to content

Fix min and max date Storybook actions for GlDatepicker

Vanessa Otto requested to merge 2686-use-design-tokens-in-gldatepicker-3 into main

What does this MR do?

This MR fixes the controls/args in Storybook for minDate and maxDate of the GlDatepicker. The control is set to be date. However, date in Storybooks returns a number. A unix timestamp. But the component expects a JavaScript date object. There is a closed issue on GitHub Storybook. The issue was closed with the "fix" telling developers to change the implementation of the story to convert a date. There was an idea to create a new control type, but I couldn't find any. Therefore, I'm now parsing all properties for min and max date now first to a Date object.

Screenshots or screen recordings

Before After
Screenshot_2024-07-05_at_12.47.05 Screenshot_2024-07-05_at_12.43.29

Integration merge requests

Not required

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Related to #2686

Edited by Vanessa Otto

Merge request reports