Skip to content

Use design tokens in GlLoadingIcon

Thomas Hutterer requested to merge 2711-use-design-tokens-in-glloadingicon into main

What does this MR do?

Closes Use design tokens in GlLoadingIcon (#2711 - closed).

Screenshots or screen recordings

spinner variant

dark (default) color

This one is used on light backgrounds.

Before After
image image
image image

light color

This one is used on dark backgrounds. See https://design.gitlab.com/components/spinner#appearance. It doesn't have to change its colors for Dark Mode:

Before After
image image
image image

Note, the "Loading" text isn't part of the component. Hence it doesn't properly change color in this example.

dots variant

dark (default) color

Before After
image image
image image

light color

Before After
image image
image image

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Thomas Hutterer

Merge request reports