Skip to content

fix(duochat): Wait for another enter to send on IME

Eduardo Bonet requested to merge ebonet/fix-japanese-imei-2 into main

What does this MR do?

fix(duochat): Wait for another enter to send on IME

When using IME such as japanese keyboard, users are given the opportunity to fix their typing before sending the message. That means formac this would require three enters (pick from list, confirm selection, and then send) and with Google keyboard IME it requires two (pick from list, and then send). So we wait for one additional enter to send the chat prompt

Normally, this is fixed using a form, but since we are adding more functionality from the slash commands this didn't seem to work on this context (example of fix using a form: gitlab!147814 (diffs))

Resolves #2537 (closed)

Screenshots or screen recordings

Google Japanese IME

Before After
2024-06-21_12.12.22 2024-06-21_12.09.35

MacOS IME

Before After
2024-06-21_12.12.44 2024-06-21_12.10.52

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Eduardo Bonet

Merge request reports

Loading