Skip to content

ci: Parallelize visual specs

Lukas 'ai-pi' Eipert requested to merge leipert-parallelize-visual-specs into main

What does this MR do?

ci: Parallelize visual specs

Because why not

test: Expose more data from screenshot tests

  1. Store the new screenshot as well and not just the diff. This means, we can simply copy paste a new screenshot over the old one. They are stored in tests/__image_snapshots__/__received_output__
  2. New tests don't have a baseline screenshot, so the mechanism from 1. doesn't work for them. Given that we calculate the filenames of the screenshot file, we can simply smuggle in a template file, so that we always have a screenshot.
  3. It is pretty tricky to know which screenshots to delete. With a sharded approach, we also would not run all screenshot tests at the same time, so we write out a file __seen_snapshots_ which contains all the screenshots the current shard has utilized.

ci: Remove visual_minimal job

Given we potentially want to move a job which updates screenshots based on the artifacts and that we now can scale visual screenshot tests horizontally, let's get rid of the minimal job.

Screenshots or screen recordings

N/A

Integration merge requests

None 😄

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Lukas 'ai-pi' Eipert

Merge request reports