Skip to content

Add a11y tests for form-combobox component

Bobby Stoynov requested to merge gitlab-community/gitlab-ui:2542-form-combobox-axe-tests into main
  • Please check this box if this contribution uses AI-generated content as outlined in the GitLab DCO & CLA

What does this MR do?

Implement automated accessibility tests for the combobox component related to #2542 as part of &11127

Screenshots or screen recordings

image

Testing

  1. Checkout this branch
  2. Run yarn
  3. Run yarn start and yarn cypress open in separate shells
  4. Click on E2E Testing -> Start E2E Testing in Chrome
  5. Navigate to http://localhost:9001/__/#/specs/runner?file=cypress/e2e/form_combobox.cy.js
  6. Verify that the tests are passing without errors and the component works as expected

formcombo

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Bobby Stoynov

Merge request reports