Skip to content

Add A11y tests for GlBroadcastMessage component

What does this MR do?

Implements the following accessibility tests for the GlBroadcastMessage component:

  • type: banner & dismissible
  • type: banner & not dismissible
  • type: banner & theme: light
  • type: notification

Also added additional test:

  • default state

Additional UI changes

Since the type: banner & theme: light test was failing due to a color contrast violation,
a few changes were added to address it:

  • update light theme background and border color
  • add black text color for banner in light theme

Screenshots

Before After
Screenshot_2024-03-29_at_11.22.05_AM Screenshot_2024-03-29_at_11.22.28_AM

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2484 (closed)

Edited by Grace Chung

Merge request reports