Skip to content

fix: Repair right alignment for table header

Marcel van Remmerden requested to merge fix-align-right-table-header into main

What does this MR do?

A previous MR broke the right alignment of table headers that was previously achieved by adding gl-text-right to thClass, so this (admittedly kind of hacky) fix brings it back.

To make this work well, we move the sort icon to the left of the label for right-aligned columns, and change from icon to glyph, which also simplifies vertical alignment.

Screenshots or screen recordings

Before After
Kapture 2024-03-12 at 15.27.07.mp4 Kapture 2024-03-12 at 15.25.54.mp4

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Marcel van Remmerden

Merge request reports