Skip to content

feat(GlDrawer): Emit "opened" event in transition after-enter hook

Thomas Hutterer requested to merge 2093-add-opened-event-to-drawer into main

What does this MR do?

Closes Add @opened event to drawer for when it complet... (#2093 - closed)

Why is this tested with Cypress?

In Jest it is tricky to test a Vue event like after-enter that is fired after a CSS transition finished. Even mocking the <transition> component didn't work, because this approach failed with the Vue 3 test suite.

Cypress tests run in a real browser where we can observe an effect of the event listener. This needed a small tweak to the storybook used by Cypress.

Screenshots or screen recordings

No visual change.

Integration merge requests

Only adds a new $emit. No integration branches required.

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Thomas Hutterer

Merge request reports

Loading