Skip to content

feat(GlCollapsibleListbox): Render correctly in button group

Mark Florian requested to merge 2263-make-new-dropdowns-render-correctly-in-button-groups into main

What does this MR do?

chore(GlButton): Remove redundant story

GlSorting has its own story, so there's no need to have another one under "button".

feat(GlCollapsibleListbox): Render correctly in button group

This makes GlCollapsibleListbox render correctly in button groups. GlDisclosureDropdown already did, and the styling used to implement that was moved to the base dropdown implementation.

Addresses #2263 (closed).

refactor(GlSorting): Remove unnecessary styling

The previous commit makes these classes redundant.

Screenshots or screen recordings

Before After
primary_confirm primary_confirm
primary_confirm_small primary_confirm_small
primary_danger primary_danger
primary_danger_small primary_danger_small
primary_default primary_default
primary_default_small primary_default_small
secondary_confirm secondary_confirm
secondary_confirm_small secondary_confirm_small
secondary_danger_small secondary_danger_small
primary_disabled disabled
disabled_small disabled_small

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2263 (closed)

Edited by Mark Florian

Merge request reports