Skip to content

fix(chat): Force a scroll-bar if we have messages

Lukas 'ai-pi' Eipert requested to merge leipert-duo-chat-move-scrollbar into main

What does this MR do?

refactor(DuoChat): Simplify Duo Chat history markup

This moves the global scrollbar to be local only for the history tab. The different levels of the DOM also have been reduced and some animations being simplified a little bit.

fix(DuoChat): Force a scroll-bar if we have messages

This will allow us to make sure that the "scrolling-to-bottom" works properly, as overflow-anchor needs an overflow to work at all.

Screenshots or screen recordings

Note Before After
As soon as we have a message, the history is always scrollable Screenshot_2024-02-19_at_23.19.31 Screenshot_2024-02-19_at_23.19.15
After this change the scrollbar just extends alongside the history, rather than the whole page Screenshot_2024-02-19_at_23.17.20 Screenshot_2024-02-19_at_23.17.42
After this change, the chat sticks to the bottom in case the first message pushes the history to be taller Screen_Recording_2024-02-19_at_23.14.21 Screen_Recording_2024-02-19_at_23.12.32

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Lukas 'ai-pi' Eipert

Merge request reports