Skip to content

DuoChat: Remove unused hero header and move global error to header

Lukas 'ai-pi' Eipert requested to merge leipert-duo-chat-cleanup into main

What does this MR do?

feat(DuoChat): Remove unused hero header

While this technically might be a breaking change, the slot is unused in the GitLab project and the VSCode Extension. We can re-add a slot if needed, but for now let's remove it.

It's gonna make some other markup changes easier.

fix(DuoChat): Move global error to header

If a global error would happen and someone has a full chat history, it would potentially be rendered outside their viewport. By moving the global error rendering to the header, we ensure that the error is visible.

It's gonna make some other markup changes easier.

Screenshots or screen recordings

Before After
Screen_Recording_2024-02-08_at_15.32.43 Screen_Recording_2024-02-08_at_15.33.20

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Lukas 'ai-pi' Eipert

Merge request reports