Skip to content

fix(DuoChat): Stick to bottom of history while streaming answers

Lukas 'ai-pi' Eipert requested to merge leipert-waterfall into main

What does this MR do?

Browsers a are pretty good at keeping the focus on an element while the parent element grows in size. With this we mark all child elements of the chat history as "non" anchors.

Right at the bottom of the chat history we add a scroll-anchor element. This scroll-anchor element is the only "possible" anchor. The beauty of it: It only will be used as an anchor if it is it is currently inside the view port.

So if the user manually scrolls up while a chunked message is coming in, it won't stick to the bottom while the message still loads.

See: https://developer.mozilla.org/en-US/docs/Web/CSS/overflow-anchor

Screenshots or screen recordings

video1512974737

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Lukas 'ai-pi' Eipert

Merge request reports