Skip to content

fix(GlCollapsibleListbox): remove aria-owns attribute from search

What does this MR do?

As raised in gitlab#436939 (closed) aria-owns on <gl-listbox-search-input> results in out from axe_clean test:

Failures:

  1) Work item for signed in user behaves like work items iteration for accessibility passes axe automated accessibility testing in open state
     Got 1 failure and 1 other error:
     Shared Example Group: "work items iteration" called from ./ee/spec/features/projects/work_items/work_item_spec.rb:22

     1.1) Failure/Error: expect(page).to be_axe_clean.within(work_item_iteration_selector)
          
            Found 1 accessibility violation:
          
            1) aria-valid-attr-value: ARIA attributes must conform to valid values (critical)
                https://dequeuniversity.com/rules/axe/4.8/aria-valid-attr-value?application=axeAPI
                The following 1 node violate this rule:
                
                    Selector: div[aria-owns="listbox-59"]
                    HTML: <div class="gl-listbox-search" aria-owns="listbox-59" data-testid="listbox-search-input">
                    Fix all of the following:
                    - Invalid ARIA attribute value: aria-owns="listbox-59"

Attempted solutions:

  • Use aria-controls instead of aria-owns
  • Move aria-owns on to the <input> element rather than the wrapping <div>
  • Move aria-controls on to the <input> element rather than the wrapping <div>

Screenshots or screen recordings

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Scott de Jonge

Merge request reports