Skip to content

fix(css): remove desktop-first CSS utils

Paul Gascou-Vaillancourt requested to merge 2376-remove-desktop-first-utils into main

What does this MR do?

feat(css): add responsive CSS utils

This adds a few responsive CSS utilities that were temporarily added to GitLab's codebase and now need to be migrated here:

  • gl-sm-flex-direction-row-reverse
  • gl-sm-w-25p
  • gl-sm-w-30p
  • gl-sm-w-40p
  • gl-sm-w-75p
  • gl-sm-mb-0

fix(css): remove desktop-first CSS utils

BREAKING CHANGE: This removes the remaining desktop-first CSS utilities form the library. Any usages of those should be replaced with mobile-first alternatives. See below for replacement suggestions. Note that the proposed replacements should work in the most simple cases. Some use cases might require using different utils combinations.

  • gl-sm-flex-direction-column Replace with gl-flex-direction-column gl-md-flex-direction-row.

  • gl-xs-flex-direction-column Replace with gl-flex-direction-column gl-sm-flex-direction-row.

  • gl-xs-w-full Replace with gl-w-full gl-sm-w-auto.

  • gl-xs-mb-3 Replace with gl-mb-3 gl-sm-mb-0.

Screenshots or screen recordings

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2376 (closed)

Edited by Paul Gascou-Vaillancourt

Merge request reports