Skip to content

chore!: remove exported scss to js scripts and usages

Elwyn Benson requested to merge 2371-remove-scss_to_js into main

What does this MR do?

Removes scss_to_js:

  • all scripts for generating it
  • all package exports
  • package.json scripts
  • pipeline references

Updates places using this. Note that there are usages in GitLab, so those should be removed before this MR is merged: Remove uses of @gitlab/ui scss_to_js (gitlab!137209 - merged)

This removal is due to the fact we have dist/tokens now, which provides similar functionality but is the preferred approach going forward.

Screenshots or screen recordings

no visual differences

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #2371 (closed)

Edited by Elwyn Benson

Merge request reports