Skip to content
Snippets Groups Projects

feat(GlTable): Add option for sticky table headers

Merged Sascha Eggenberger requested to merge table-add-sticky-header-option into main
All threads resolved!

What does this MR do?

Adds the ability to set the table headers sticky:

  • Adds a new prop sticky-header
  • Default is false

Why this change?

Some list pages could benefit of having sticky table headers for better orientation.

Screenshots or screen recordings

Before After
before after

http://localhost:9001/?path=/story/base-table-table--with-sticky-header

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Sascha Eggenberger

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 550b8b89 - feat(GlTable): Add option for sticky table headers

    Compare with previous version

  • Dan MH approved this merge request

    approved this merge request

  • Jacques Erasmus approved this merge request

    approved this merge request

  • Jacques Erasmus requested review from @psimyn and removed review request for @jerasmus

    requested review from @psimyn and removed review request for @jerasmus

  • Ghost User added 1 commit

    added 1 commit

    Compare with previous version

  • Simon Knox
  • Simon Knox
  • added 1 commit

    Compare with previous version

  • Simon Knox removed review request for @psimyn

    removed review request for @psimyn

  • mentioned in issue danmh/danmh#23 (closed)

  • Sascha Eggenberger changed milestone to %16.5

    changed milestone to %16.5

  • Sascha Eggenberger added 55 commits

    added 55 commits

    Compare with previous version

  • Sascha Eggenberger requested review from @psimyn

    requested review from @psimyn

  • added 1 commit

    • e3321e3a - feat(GlTable): Update styles

    Compare with previous version

  • Simon Knox resolved all threads

    resolved all threads

  • Simon Knox approved this merge request

    approved this merge request

  • Simon Knox added 1 commit

    added 1 commit

    • 68f814da - feat(GlTable): Add option for sticky table headers

    Compare with previous version

  • Simon Knox resolved all threads

    resolved all threads

  • Simon Knox enabled automatic add to merge train when the pipeline for 5a8a6731 succeeds

    enabled automatic add to merge train when the pipeline for 5a8a6731 succeeds

  • Simon Knox started a merge train

    started a merge train

  • merged

  • Simon Knox mentioned in commit 5ac01351

    mentioned in commit 5ac01351

  • Please register or sign in to reply
    Loading