Skip to content

refactor: Add new design tokens

Peter Hegman requested to merge add-more-design-tokens into main

What does this MR do?

Related to &10980. We are hoping to migrate to Tailwind in the future and would like to use the design tokens to build our tailwind.config.js file so we have consistency. This MR adds line-height design tokens. We will add more tokens in the future.

The structure of the tokens follows these guidelines.

Screenshots or screen recordings

This is what the tokens look like after being built

JS

Screenshot_2023-09-13_at_2.18.50_PM

CSS

Screenshot_2023-09-13_at_2.19.14_PM

SCSS

Screenshot_2023-09-13_at_2.19.26_PM

Integration merge requests

We are not actually integrating into any of these projects yet so I don't think we need integration MRs quite yet.

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • [-] Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • [-] All actions and functionality can be done with a keyboard.
  • [-] Links, buttons, and controls have a visible focus state.
  • [-] All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • [-] Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • [-] Color combinations have sufficient contrast.
Edited by Peter Hegman

Merge request reports