Skip to content

fix(GlCollapsibleListbox): revert to previous clear all logic

Paul Gascou-Vaillancourt requested to merge revert-27b47835 into main

What does this MR do?

Reverts fix(GlCollapsibleListbox): reverse clear all logic (!3523 - merged). It broke some Jest spec in GitLab in a way that might indicate that the impact of the change was not properly weighted:

FAIL spec/frontend/analytics/shared/components/projects_dropdown_filter_spec.js
  ● ProjectsDropdownFilter component › highlighted items › with a selected project › renders the clear all button
    expect(received).toBe(expected) // Object.is equality
    Expected: true
    Received: false
      173 |         await selectDropdownItemAtIndex([0], false);
      174 |
    > 175 |         expect(findClearAllButton().exists()).toBe(true);
          |                                               ^
      176 |       });
      177 |
      178 |       it('clears all selected items when the clear all button is clicked', async () => {
      at Object.toBe (spec/frontend/analytics/shared/components/projects_dropdown_filter_spec.js:175:47)

We seem to have forgotten to create an integration MR where we could have caught the failure and decided on the best course of action before merging the GitLab UI change. For now, it might be safer to revert the change rather than address the failure in a hurry.

Broken upgrade MR: gitlab!123927 (merged)

Screenshots or screen recordings

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Merge request reports