Skip to content

feat(Typography): add text size scale variables

Dan MH requested to merge type-scale-updates-1-danmh into main

What does this MR do?

This MR is part of series of MRs to make GitLab use the new type scale for headings Typography > Type scale (gitlab-org/gitlab-services&15).

This MR adds the underlying sizes to be used for typography across GitLab.

In an effort to keep MRs small, these variables are not used as part of this MR.

The goal is for all typography to point back to this scale eventually. Either directly, or through different levels of abstraction and aliasing. For example alert-headingh4 (styles)$gl-text-font-size-400-dynamic, but exact naming and process TBD.

The styles were tested in Figma and in a temporary project.

Underlying scale Heading values
image image

Next steps

Here is the plan for future MRs, but comments and advice appreciated.

Screenshots or screen recordings

No visible changes

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Dan MH

Merge request reports