feat(dropdowns): adds support for fixed positioning strategy
What does this MR do?
feat(dropdowns): adds support for fixed positioning strategy
This adds support for the fixed
positioning strategy, which can be
useful when a dropdown is contained within a short element that might
cause it to be cut off. Applying this positioning strategy would let the
dropdown position itself above the container, ignorning its size
constraints.
This is done primarily to migrate gitlab!120393 (merged) to Floating UI. In that MR, the popper-options
prop was used to set a custom positioning strategy, which was not taken into account when we upgraded to Floating UI. This restores the ability to set the strategy via a new positioningStrategy
.
Screenshots or screen recordings
Before (using Floating UI without this fix) | After |
---|---|
Integration merge requests
-
GitLab: gitlab!121070 (merged) - [-] CustomersDot: mr_url
- [-] Status Page: mr_url
Does this MR meet the acceptance criteria?
This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.
Toggle the acceptance checklist
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidelines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above). -
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.