Skip to content

Resolve "Charts: tooltip cannot display in edge"

xu huihuang requested to merge x--/gitlab-ui:2230-chart-tooltip into main

What does this MR do?

Related issue: #2230 (closed)

/cc @prajnamas @JeremyWuuuuu @qk44077907 @fenyuluoshang @lxwan

  • fix charts tooltip cannot display in edge problem
  • add cypress edge e2e test to cy:run
  • add/update chart component e2e test

Cause of the problem: use getDom() to bind event, then, use zrX and zrY which are not included in the native event to get the relative position, in firefox/chrome browser, echarts has inject the value (it's out of specification), in edge, not injected, so tooltip can not display correctly.

Correction method: use the standard getZr() to get zrender instance to bind the event.

Ps: storybook.cy.js also has some problems in edge e2e test, maybe it should be fixed in another issue.

Screenshots or screen recordings

before after
屏幕录制2023-05-15_16.54.50 屏幕录制2023-05-15_16.53.16

Integration merge requests

Does this MR meet the acceptance criteria?

This checklist encourages the authors, reviewers, and maintainers of merge requests (MRs) to confirm changes were analyzed for conformity with the project's guidelines, security and accessibility.

Toggle the acceptance checklist

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidelines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened (see integration merge requests above).
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by xu huihuang

Merge request reports