Skip to content

fix(GlSparklineChart): Hide tooltip for blank data in the series

Alex Pennells requested to merge sparkline-broken-tooltips into main

What does this MR do?

Related to: gitlab#391739 (closed)

Handles the case that we have some bad data in our Sparkline (null or undefined). In that case we don't want to render the tooltip for the missing points

Before Screenshot_2023-04-10_at_2.18.33_PM
After Screenshot_2023-04-10_at_2.18.19_PM

Local testing

  • Run storybook yarn start
  • Navigate to SparklineChart
  • Change the value of the data prop:
[
  ["Mon", 10],
  ["Tue", 15],
  ["Wed", null],
  ["Thu", 22],
  ["Fri", 29],
  ["Sat", 20],
  ["Sun", 18]
]

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Alex Pennells

Merge request reports