feat(toggle): Add description text and inline variant
What does this MR do?
Adds the missing description
field ands adds a new variant to Storybook for the inline label variant.
Specs: Pajamas, Figma
Before | After |
---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
CustomersDot: mr_url -
Status Page: mr_url
-
-
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Closes #2148 (closed)
Merge request reports
Activity
changed milestone to %Next 1-3 releases
assigned to @seggenberger
marked the checklist item If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. as completed
📦 Minor release (conventional commits)This Merge Request will trigger a minor release of GitLab UI, triggered by commit: da0d5aae
This will bump the second part of the version number, e.g.
v1.2.3
->v1.3.0
.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Andrew Fontaine ( @afontaine
) (UTC-5, 6 hours behind@seggenberger
)Paul Slaughter ( @pslaughter
) (UTC-6, 7 hours behind@seggenberger
)UX Matthew Nearents ( @mnearents
) (UTC-8, 9 hours behind@seggenberger
)Maintainer review is optional UX Review
Component Reviewer component:toggle @pedroms
If your Merge Request changes one or more components, please have it reviewed by a Product Designer. One should have been suggested above. Otherwise, or if they are not available, feel free to assign to a UX Foundations designer:
If needed, you can retry the
🔁 danger-review
job that generated this comment.Generated by
🚫 DangerHey @afontaine
👋 do you mind reviewing this change? TY!requested review from @afontaine
added frontend label
mentioned in commit bf0f4a55
This looks good to me, thanks @seggenberger
@pedroms, @pslaughter can you review this?
requested review from @pedroms and @pslaughter and removed review request for @afontaine
- Resolved by Sascha Eggenberger
- Resolved by Sascha Eggenberger