Skip to content

fix(GlListbox): Override margin and width of reset button

Tan Le requested to merge tl-force-reset-button-margin-listbox into main

What does this MR do?

When working on the GlCollapsibleListbox migration issue, we have noted that the Clear button is misaligned in the admin project list page (see relevant thread) on small viewports. The button style is cascaded down via the navigation control wrapper (see style).

styles in developer toolbard

This MR proposes to override the margin and width styles with !important. I can't help to think that there could be a more elegant solution. I am not a CSS expert so definitely open to any feedback and suggestion.

Screenshots

Screen Before After
Desktop desktop before desktop after
Mobile mobile before mobile after

How to set up and validate locally

  1. View the admin projects page (http://gdk.test:3000/admin/projects) on a mobile viewport
  2. Select a namespace in the namespace listbox
  3. Observe the alignment issue of the Clear button
  4. Copy the override classes gl-w-auto! gl-m-0! to the button

override button styles

  1. Verify that the alignment issue is fixed

Notes: I have tried to test this change using yarn link and yalc (see instructions) but encountered a lot of compilation issues. Eventually, I resorted to the manual steps described above 👆🏼.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Tan Le

Merge request reports