fix(GlDropdownItem): Fix dropdown item disabled state styling
What does this MR do?
This MR fixes GlDropdownItem
not looking disabled when the disabled
attribute is added to it.
Before | After |
---|---|
![]() |
![]() |
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
CustomersDot: mr_url -
Status Page: mr_url
-
-
Added the ~"component:*"
label(s) if applicable.
Closes #2092 (closed)
Merge request reports
Activity
added UX component:dropdown devopsmanage frontend groupfoundations sectiondev + 1 deleted label
assigned to @dftian
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
removed devopsmanage label
added devopsmanage label
Patch release (conventional commits)This Merge Request will trigger a patch release of GitLab UI, triggered by commit: 057c4dce
This will bump the third part of the version number, e.g.
v1.2.3
->v1.2.4
.Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer frontend Scott de Jonge (
@sdejonge
) (UTC+11, 21 hours ahead of@dftian
)Olena HK. (
@ohoral
) (UTC+1, 11 hours ahead of@dftian
)UX Andy Volpe (
@andyvolpe
) (UTC-5, 5 hours ahead of@dftian
)Maintainer review is optional UX Review
Component Reviewer component:dropdown @jeldergl
If your Merge Request changes one or more components, please have it reviewed by a Product Designer. One should have been suggested above. Otherwise, or if they are not available, feel free to assign to a UX Foundations designer:
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1 commit
- f71f234a - fix(GlDropdownItem): Fix dropdown item disabled state styling
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@dftian - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
- Resolved by Scott de Jonge
- Resolved by Mark Florian
- Resolved by Mark Florian
added typemaintenance label
added typebug label and removed typemaintenance label
added bugux label
- Resolved by Annabel Dunstone Gray
@annabeldunstone Would you be able to do the UX review for this one?
requested review from @annabeldunstone
- Resolved by Mark Florian
requested review from @sdejonge
added 1 commit
- 4cbc8aca - fix(GlDropdownItem): Fix dropdown item disabled state styling
removed review request for @annabeldunstone
added 1 commit
- 057c4dce - fix(GlDropdownItem): Fix dropdown item disabled state styling
@markrian Would you be able to do the maintainer review for this one?
- Resolved by Mark Florian
changed milestone to %15.7
mentioned in commit 032b0916
mentioned in merge request gitlab!106199 (merged)