Skip to content
Snippets Groups Projects

fix(GlDropdownItem): Fix dropdown item disabled state styling

Merged Daniel Tian requested to merge 2092-fix-dropdown-item-disabled-state into main
All threads resolved!

What does this MR do?

This MR fixes GlDropdownItem not looking disabled when the disabled attribute is added to it.

Before After
ksnip_20221129-150428 ksnip_20221129-143932

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Closes #2092 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Daniel Tian
  • Daniel Tian
  • Daniel Tian added typebug label and removed typemaintenance label

    added typebug label and removed typemaintenance label

  • added bugux label

  • requested review from @annabeldunstone

  • Daniel Tian requested review from @sdejonge

    requested review from @sdejonge

  • Daniel Tian added 1 commit

    added 1 commit

    Compare with previous version

  • Daniel Tian added 1 commit

    added 1 commit

    • 4cbc8aca - fix(GlDropdownItem): Fix dropdown item disabled state styling

    Compare with previous version

  • removed review request for @annabeldunstone

  • Daniel Tian added 1 commit

    added 1 commit

    • 057c4dce - fix(GlDropdownItem): Fix dropdown item disabled state styling

    Compare with previous version

  • Scott de Jonge approved this merge request

    approved this merge request

  • Annabel Dunstone Gray approved this merge request

    approved this merge request

  • Author Developer

    @markrian Would you be able to do the maintainer review for this one? :bow:

  • Daniel Tian requested review from @markrian and removed review request for @sdejonge

    requested review from @markrian and removed review request for @sdejonge

  • Mark Florian
  • Mark Florian resolved all threads

    resolved all threads

  • Mark Florian changed milestone to %15.7

    changed milestone to %15.7

  • Mark Florian started a merge train

    started a merge train

  • Mark Florian approved this merge request

    approved this merge request

  • merged

  • Mark Florian mentioned in commit 032b0916

    mentioned in commit 032b0916

  • Daniel Tian mentioned in merge request gitlab!106199 (merged)

    mentioned in merge request gitlab!106199 (merged)

  • Please register or sign in to reply
    Loading