Skip to content

fix(charts): Update chart toolbar icons

Laurent Deketelaere requested to merge ali_o_kan/gitlab-ui:1902-update-toolbox-icons into main

What does this MR do?

Follow-up !3174 (comment 1181881909)

Finally, I just noticed that the icons currently on the gitlab-UI toolbox component are out-of-date. We went through and updated all of the icons a year or so ago, and I think the chart component icons never got updated 🤦 Is that something you'd be willing to update here as well? I believe it would be just updating the icon references, so what's shown in the component library better matches the icons actually in use in the product.

If you're willing to make that change, the updated icons are in the icon library (marquee selection, redo, repeat, download). It's okay if not, though, I can make a follow-up issue, too.

Before

image

After

image

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Merge request reports