Skip to content

chore(vue3): avoid binding tree instance method inside constructor

Illya Klymov requested to merge xanf-road2vue3-form-checkbox-tree into main

What does this MR do?

We're avoiding .bind(this) in model. In that case invoking tree.someMethod() in Vue3 from Vue component will have this pointing to Proxy, so reactivity will be preserved

This is forward-compatible change to support @vue/compat #1981 (closed)

Closes #1718 (closed)

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Merge request reports