Skip to content

chore(vue3): use props() instead of attributes() to assert props

Illya Klymov requested to merge xanf-road2vue3-alerts into main

What does this MR do?

This MR fixes usage of attributes() for building assertion for component.

This works for Vue2, but will fail in Vue3, where attributes and props are separated in a "better" way

This is forward-compatible change to support @vue/compat #1981 (closed)

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Merge request reports