Skip to content

fix(GlDropdown): Auto adjust position

Savas Vedova requested to merge 1965-fix-dropdown-positioning into main

What does this MR do?

This MR is a temporary fix until we migrate to Bootstrap Vue 5 (see #1417 (comment 1103446339) for more information on this).

Currently the Dropdown component does not auto adjust its position based on the remaining space so we see the dropdown being but off by the screen (example below).

This MR adds a temporary fix which computes the remaining space onmousedown and specifies a position accordingly. I didn't provide an onresize event intentionally because this already improves the existing behaviour and I didn't want to add extra complexity on it. I believe if we receive feedback on that edge case, we can iterate and create a new MR.

Screenshots

before
image
after
dropdown

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #1965 (closed)

Edited by Savas Vedova

Merge request reports