Skip to content

fix(css): ensure we correctly generate gl-flex-direction-column utils

Ezekiel Kigbo requested to merge ek-fix-gl-flex-direction-responsive-utils into main

What does this MR do?

It looks like the gl-*-flex..! variants of utilities were not being correctly generated. This MR re-orders the gl-*-flex-direction-column mixins to ensure we define gl-flex-direction-column before all the gl-*-flex-direction-column variants. Locally this appears to fix the outputted build.

This was noticed by @23bytes in gitlab#368329 (comment 1076709139)

You can verify this by comparing the output of src/scss/utilities.scss after creating a new build.

Before After
Screen_Shot_2022-08-25_at_10.29.25_am Screen_Shot_2022-08-25_at_10.23.19_am

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Ezekiel Kigbo

Merge request reports