Skip to content

feat: Add empty and readonly states for token-selector component

Natalia Tepluhina requested to merge ntepluhina-add-token-selector-view-only into main

What does this MR do?

This MR adds two features to GlTokenSelector component:

  1. A slot to pass down content to be shown when tokens list is empty and input is not focused
  2. A viewOnly prop that is passed down to tokens and removes X icon from them. Also, this prop hides the dropdown, making editing tokens impossible

Why do we need these changes?

Please check designs of the work item assignees component here for the context: gitlab#334810 (designs)

Placeholder content demo

placeholder

View-only state demo

viewOnly

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Natalia Tepluhina

Merge request reports