Skip to content

Draft:Fix tabs query params

James Rushford requested to merge fix-tabs-query-params into main

What does this MR do?

Current state uses tab index in url, change uses queryParamValue when available and tab index when not available.

Also fixed StoryBook use of syncActiveTabWithQueryParams

default tab tab with queryParamValue tab without queryParamValue
Screenshot_2022-05-04_at_15.34.23 Screenshot_2022-05-04_at_15.34.36 Screenshot_2022-05-04_at_15.34.31

To test: Testing in StoryBook main page does not work as it makes use of an iframe, but you can test by opening the example in a new window or using this link for local running instances

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by James Rushford

Merge request reports