Skip to content

feat(GlTab): add tab counter badge variants

- requested to merge 1778-fix-badge-varients into main

What does this MR do?

Enables support for Tab counter varients. See discussion thread for UX team guidance. #1778 (comment 926517785)

Notes from UX team:

  • When a tab is active, the background color stays the same.
  • When a tab is active, the count color remains the same, it is only bolded.

Before

Screen_Shot_2022-05-01_at_12.07.15_AM

After

Screen_Shot_2022-05-01_at_12.01.36_AM

Screen_Shot_2022-05-01_at_12.01.46_AM

Screen_Shot_2022-05-01_at_12.01.52_AM

Screen_Shot_2022-05-01_at_12.01.58_AM

Screen_Shot_2022-05-01_at_12.02.07_AM

Screen_Shot_2022-05-01_at_12.02.13_AM

Screen_Shot_2022-05-01_at_12.02.20_AM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #1778 (closed)

Edited by -

Merge request reports