Skip to content

fix(GlButton): Fix button text color in dark mode

Simon Knox requested to merge dark-button-text into main

What does this MR do?

Use the rule added in !2778 (merged) to not invert button text color in dark mode.

gl-text-white is #333 in dark mode (that is not ideal but it is the situation for now..). So instead we use this value intended as light text contrast color.

before after
Screen_Shot_2022-04-27_at_3.45.59_pm Screen_Shot_2022-04-27_at_3.45.46_pm
Screen_Shot_2022-04-27_at_3.46.43_pm Screen_Shot_2022-04-27_at_3.46.31_pm
Screen_Shot_2022-04-27_at_3.47.22_pm Screen_Shot_2022-04-27_at_3.47.34_pm

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Accessibility

Edited by Simon Knox

Merge request reports