Adding some changes
What does this MR do?
Does this MR meet the acceptance criteria?
Conformity
-
Code review guidelines. -
GitLab UI's contributing guidlines. -
If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer. -
If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer. -
If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui
package can be upgraded quickly after the changes are released:-
GitLab: mr_url -
CustomersDot: mr_url -
Status Page: mr_url
-
-
Added the ~"component:*"
label(s) if applicable.
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
Security reports checked/validated by a reviewer from the AppSec team
Accessibility
If this MR adds or modifies a component, take a few moments to review the following:
-
All actions and functionality can be done with a keyboard. -
Links, buttons, and controls have a visible focus state. -
All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label
for icons that have meaning or perform actions. -
Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false"
toaria-expanded="true"
when an accordion is expanded. -
Color combinations have sufficient contrast.
Merge request reports
Activity
Thank you for your contribution to GitLab. We believe that everyone can contribute and contributions like yours are what make GitLab great!
- Our Merge Request Coaches will ensure your contribution is reviewed in a timely manner*.
- You can comment
@gitlab-bot label ~"group::"
to add a group label. - After a few days, feel free to ask
@gitlab-bot help
or ping a Merge Request Coach. - Read more how to get help.
This message was generated automatically. You're welcome to improve it.
added Community contribution label
added documentation twtriaged labels
added Hackathon label
added 1st contribution label
mentioned in issue gitlab-org/quality/triage-reports#4703 (closed)
Thank you for the contribution, @ankita.singh.200020
@aqualls can you review this community contribution? Thanks
requested review from @aqualls
assigned to @ankita.singh.200020
- Resolved by Marcia Ramos
@aturinske I'm hesitant to step in here. The TW team doesn't normally work on the
gitlab-ui
repository, and some of these changes are more significant than just tone / style cleanup. I think someone involved with thegitlab-ui
repo should review this work. I'm not sure who that someone is.Complicating factor: Tomorrow is a company holiday, so no one will be here, and I am about to be on PTO until October 7. I probably cannot find out who is responsible before I leave.
@dianalogan, I'm passing this merge request over to you for reassignment. I'm not sure where we should route it or who outside the TW team should read it, and there's no one here to ask today. I've sent Craig enough stuff today, so I thought I'd even the load a little.
removed review request for @aqualls
assigned to @dianalogan
@ankita.singh.200020 could you please edit this merge request to provide us some information about this MR? Is this merge request related to an issue somewhere?
mentioned in issue gitlab-org/quality/triage-reports#4705 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4754 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4766 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4768 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4770 (closed)
mentioned in issue gitlab-org/quality/triage-reports#4772 (closed)
@ankita.singh.200020
Hi there - does this update relate to an issue?mentioned in issue gitlab-org/quality/triage-reports#4841 (closed)
added sectiondev label
@cnorris - can you suggest someone to reassign to? thanks!
- Resolved by Mark Florian
@marcia - I see you listed as a codeowner for this info. Is this something you can help with? Thanks!
Mentioning @dianalogan for awareness.
unassigned @dianalogan
requested review from @marcia
changed milestone to %14.5
added Technical Writing development guidelines docsimprovement tw-weight3 twfinished labels and removed twtriaged label
- Resolved by Mark Florian
added awaiting feedback label
removed review request for @marcia
added typemaintenance label
- Resolved by Mark Florian
Hi @ankita.singh.200020, thanks for working on this. This MR is listed as an idle MR in our weekly community contributions report (gitlab-org/quality/triage-reports#6428 (closed)).
I'm going to manually label this MR as vintage. This means that unless there's a response from you in the next 7 days it will automatically be closed. Please note that we can reopen the MR at any point after the 7 day period. We're closing MRs to improve our signal to noise ratio on community MRs.
We greatly appreciate your effort here. If at any point in future you decide to continue working on this, we can always reopen it.
added vintage label
removed vintage label
mentioned in issue gitlab-org/quality/triage-reports#6583 (closed)
mentioned in issue gitlab-org/quality/triage-reports#6690 (closed)
mentioned in issue gitlab-org/quality/triage-reports#6849 (closed)
added idle label
removed idle label
added idle label
removed idle label
added idle label
removed idle label
added idle label
removed idle label
added idle label
removed idle label
added idle label
removed idle label
added idle label
removed idle label
mentioned in issue gitlab-org/quality/triage-reports#6915 (closed)
added idle label
removed idle label
added idle label
removed idle label
mentioned in issue gitlab-org/quality/triage-reports#7080 (closed)
added idle label
added workflowin dev label
removed milestone %14.5
Hi @rymai!
To provide a better contribution experience, we're identifying older merge requests with no human activity in the past 120 days. Our goal is to bring these merge requests to completion or close them, enabling us to spend more time on active merge requests.
Review this merge request and determine if you should:
- Bring it closer to completion.
- Close it.
- Ask for help from a merge request coach.
Please see the handbook for additional details on this
added automation:stale-reminded label
removed stale label
- Resolved by Mark Florian
@dmishunov If these changes still make sense to you, could you please apply the suggestion and rebase (I think you should be able to do it yourself since people who can merge tot his project are able to push commits to this branch).
@gitlab-bot ready @dmishunov
added workflowready for review label and removed workflowin dev label
requested review from @dmishunov
@dmishunov
, this Community contribution is ready for review.- Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
- Add the workflowin dev label if the merge request needs action from the author.
This message was generated automatically. You're welcome to improve it.
requested review from @markrian and removed review request for @dmishunov
1 Warning This MR will trigger no release Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.
Category Reviewer Maintainer documentation No reviewer available No maintainer available If needed, you can retry the
danger-review
job that generated this comment.No release
This Merge Request will trigger no release. This means none of the commits warrant a semantic release according to conventional commits rules (e.g. they only update CI config).
To trigger a release, update one or more commit messages.
Generated by
Dangeradded coach will finish label
added 1299 commits
-
582b7270...2aeabd5a - 1298 commits from branch
gitlab-org:main
- 61b1f793 - docs: Simplify wording for complex changes
-
582b7270...2aeabd5a - 1298 commits from branch
- Resolved by Mark Florian
- Resolved by Mark Florian
enabled automatic add to merge train when the pipeline for faa45dfa succeeds
changed milestone to %15.3
mentioned in commit 0c4d142c
@ankita.singh.200020, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:
- Leave a
or a on this comment to describe your experience. - Create a new comment starting with
@gitlab-bot feedback
below, and leave any additional feedback you have for us in the comment.
Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
- Leave a
added devopsmanage label and removed 1 deleted label