Skip to content
Snippets Groups Projects

Adding some changes

All threads resolved!

What does this MR do?

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marcia Ramos removed review request for @marcia

    removed review request for @marcia

    • Resolved by Mark Florian

      Hi @ankita.singh.200020, thanks for working on this. This MR is listed as an idle MR in our weekly community contributions report (gitlab-org/quality/triage-reports#6428 (closed)).

      I'm going to manually label this MR as vintage. This means that unless there's a response from you in the next 7 days it will automatically be closed. Please note that we can reopen the MR at any point after the 7 day period. We're closing MRs to improve our signal to noise ratio on community MRs.

      We greatly appreciate your effort here. If at any point in future you decide to continue working on this, we can always reopen it.

  • added vintage label

  • removed vintage label

  • added idle label

  • removed idle label

  • added idle label

  • removed idle label

  • added idle label

  • removed idle label

  • added idle label

  • removed idle label

  • added idle label

  • removed idle label

  • added idle label

  • removed idle label

  • added idle label

  • removed idle label

  • added idle label

  • removed idle label

  • added idle label

  • removed idle label

  • Matija Čupić added 1 deleted label

    added 1 deleted label

  • added idle label

  • Rémy Coutable removed 1 deleted label

    removed 1 deleted label

  • Rémy Coutable removed milestone %14.5

    removed milestone %14.5

  • 🤖 GitLab Bot 🤖 added stale label and removed idle label

    added stale label and removed idle label

  • Hi @rymai! :wave:

    To provide a better contribution experience, we're identifying older merge requests with no human activity in the past 120 days. Our goal is to bring these merge requests to completion or close them, enabling us to spend more time on active merge requests.

    Review this merge request and determine if you should:

    Please see the handbook for additional details on this

    (Improve this message?)

  • removed stale label

  • requested review from @dmishunov

  • @dmishunov, this Community contribution is ready for review.

    • Do you have capacity and domain expertise to review this? We are mindful of your time, so if you are not able to take this on, please re-assign to one or more other reviewers.
    • Add the workflowin dev label if the merge request needs action from the author.

    This message was generated automatically. You're welcome to improve it.

  • Denys Mishunov requested review from @markrian and removed review request for @dmishunov

    requested review from @markrian and removed review request for @dmishunov

  • Mark Florian added 1 commit

    added 1 commit

    • 582b7270 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • 1 Warning
    :warning: This MR will trigger no release

    Reviewer roulette

    Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category and by a maintainer in all other categories.

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, mention them as you normally would! Danger does not automatically notify them for you.

    Category Reviewer Maintainer
    documentation No reviewer available No maintainer available

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    No release

    This Merge Request will trigger no release. This means none of the commits warrant a semantic release according to conventional commits rules (e.g. they only update CI config).

    To trigger a release, update one or more commit messages.

    Generated by :no_entry_sign: Danger

  • Mark Florian added 1299 commits

    added 1299 commits

    Compare with previous version

  • Mark Florian
  • Mark Florian
  • Mark Florian approved this merge request

    approved this merge request

  • Mark Florian resolved all threads

    resolved all threads

  • Mark Florian enabled automatic add to merge train when the pipeline for faa45dfa succeeds

    enabled automatic add to merge train when the pipeline for faa45dfa succeeds

  • Mark Florian changed milestone to %15.3

    changed milestone to %15.3

  • Mark Florian started a merge train

    started a merge train

  • Mark Florian mentioned in commit 0c4d142c

    mentioned in commit 0c4d142c

  • merged

  • @ankita.singh.200020, how was your code review experience with this merge request? Please tell us how we can continue to iterate and improve:

    1. Leave a :thumbsup: or a :thumbsdown: on this comment to describe your experience.
    2. Create a new comment starting with @gitlab-bot feedback below, and leave any additional feedback you have for us in the comment.

    Have five minutes? Take our survey to give us even more feedback on how GitLab can improve the contributor experience.

    Thanks for your help! :heart:

    This message was generated automatically. You're welcome to improve it.

  • 🤖 GitLab Bot 🤖 added devopsmanage label and removed 1 deleted label

    added devopsmanage label and removed 1 deleted label

  • Please register or sign in to reply
    Loading