Skip to content

fix(charts): change zoom-bar to match designs specs

David Pisek requested to merge 1445-follow-up-from-feat-echarts-update-to-echarts-5 into main

What does this MR do?

Currently the only chart component that sets the options related to a chart's zoom-bar in accordance with the design specs is GlLineChart.

In an upcoming MR the option that controls this will be removed from the line-chart component.

In order to keep the existing functionality aligned to the design-specs and increase overall consistency, this MR moves the zoom-bar options into the globally shared chart's theme.

Components affected

  • GlAreaChart
  • GlBarChart
  • GlColumnChart
  • GlDiscreteScatterChart
  • GlLineChart
  • GlStackedColumnChart

Screenshots

design
Screen_Shot_2021-06-08_at_1.05.53_PM

See storyshot diffs for visual changes.

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.

Closes #1445 (closed)

Edited by David Pisek

Merge request reports