Skip to content

fix(GlSafeLinkDirective): pass arguments to `update` hook

Peter Hegman requested to merge peterhegman/fix-v-safe-link-update-hook into main

What does this MR do?

Related to gitlab#331355 (closed)

In !2191 (merged) we added v-safe-html to GlButton but there is an issue with v-safe-html where the skipSanitization argument is not respected in the update hook. This is because the binding argument is not passed to the update hook.

Currently this bug is affecting the "Download codes" button in the 2FA setup flow, but it may be affecting other parts of the codebase.

Before After
Screen_Recording_2021-06-28_at_12.55.59_PM Screen_Recording_2021-06-28_at_1.18.02_PM

Does this MR meet the acceptance criteria?

Conformity

Edited by Peter Hegman

Merge request reports

Loading