Skip to content

refactor(GlLabel): Use GlButton for label close button

Tom Quirk requested to merge 1104-use-glbutton-to-remove-label into main

What does this MR do?

Refactors component:label to use close_button.vue (effectively, GlButton).

In order to achieve this, a reset variant is added to GlButton.

Related to #1104 (closed).

Demo

Demo environment: gitlab-ui linked to main GitLab project

labels-demo

Variations

Default Hover
Light Text Screen_Shot_2021-05-10_at_4.34.46_pm Screen_Shot_2021-05-10_at_4.34.49_pm
Dark Text Screen_Shot_2021-05-10_at_4.34.15_pm Screen_Shot_2021-05-10_at_4.34.24_pm
Light Text (Scoped) Screen_Shot_2021-05-10_at_4.34.56_pm Screen_Shot_2021-05-10_at_4.35.00_pm
Dark Text (Scoped) Screen_Shot_2021-05-19_at_10.23.11_pm Screen_Shot_2021-05-19_at_10.23.18_pm
Dark Text - disabled Screen_Shot_2021-05-11_at_4.53.07_pm -
Light Text - disabled Screen_Shot_2021-05-11_at_4.53.16_pm -
Dark Text (Scoped) - disabled Screen_Shot_2021-05-11_at_4.53.00_pm -
Light Text (Scoped) - disabled Screen_Shot_2021-05-11_at_4.52.41_pm -

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Tom Quirk

Merge request reports