Skip to content

fix(GlDropdown): Dropdown icon only fix with textSrOnly

Problem

Dropdowns that contain icon, text, text-sr-only, and no-caret don't receive the dropdown-icon-only class, which results in extra right padding. There are only a few edge cases where this exists, but it could more in the future, since most of these can be defined in the component properties themselves, resulting in cleaner code. This makes it possible to not have to use a template #button-content:

No template:

<gl-dropdown
      icon="ellipsis_v"
      :text="dropdownText"
      :text-sr-only="true"
      no-caret
      right
    >

Same output, but using a template and needing to import GlIcon:

<gl-dropdown
      no-caret
      right
    >
      <template #button-content>
        <gl-icon name="ellipsis_v" />
        <span class="gl-sr-only">{{ dropdownText }}</span>
      </template>
Before After
Screen_Shot_2021-04-01_at_12.09.56_PM Screen_Shot_2021-04-01_at_12.09.19_PM

Where in the product do these scenarios exist?

WIP: Issue actions dropdown Diff settings dropdown (you can see the extra padding between the icons)
Screen_Shot_2021-04-01_at_11.59.01_AM Screen_Shot_2021-04-01_at_12.00.01_PM

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Accessibility

If this MR adds or modifies a component, take a few moments to review the following:

  • All actions and functionality can be done with a keyboard.
  • Links, buttons, and controls have a visible focus state.
  • All content is presented in text or with a text equivalent. For example, alt text for SVG, or aria-label for icons that have meaning or perform actions.
  • Changes in a component’s state are announced by a screen reader. For example, changing aria-expanded="false" to aria-expanded="true" when an accordion is expanded.
  • Color combinations have sufficient contrast.
Edited by Jarek Ostrowski

Merge request reports