Skip to content

feat(css): Add gl-table-layout-fixed class

Miguel Rincon requested to merge mrincon-add-table-layout-util into master

What does this MR do?

  1. Add a new utilities file for table properties: src/scss/utility-mixins/table.scss
    • Why this new file? There are many CSS properties that are specific to tables, and we can group them in this file. Also other utilities files didn't fit this grouping 🤷
  2. Add a new fixed layout util class
    • Why this property? Even though we have a fixed prop in <gl-table> we still have a few use cases in HAML and plain HTML to create simpel tables with fixed layouts (also fixed layouts a more performant!)

See a related use case: gitlab!51021 (merged)

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • [-] If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • [-] If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • [-] If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Miguel Rincon

Merge request reports