Skip to content

Fix(GlFormSelect): stop text overflowing into right icon

David O'Regan requested to merge form-select-padding-right into master

What does this MR do?

A small MVC for gitlab#295307 (closed) to solve a ~bug that was causing the text to overflow into the right dropdown icon. This is done by un-setting the left and right padding mixin.

Before After
Screenshot_2020-12-22_at_19.08.49 Screenshot_2020-12-22_at_19.08.36

Does this MR meet the acceptance criteria?

Conformity

  • Code review guidelines.
  • GitLab UI's contributing guidlines.
  • If it changes a Pajamas-compliant component's look & feel, the MR has been reviewed by a UX designer.
  • If it changes GitLab UI's documentation guidelines, the MR has been reviewed by a Technical Writer.
  • If the MR changes a component's API, integration MR(s) have been opened in the following projects to ensure that the @gitlab/ui package can be upgraded quickly after the changes are released:
  • Added the ~"component:*" label(s) if applicable.

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports